Skip to content

fix(ci): a spec leaving the index is not a spec that got fixed - #2444

Merged
gHashTag merged 2 commits into
masterfrom
fix/departure-is-not-repair
Aug 22, 2026
Merged

gHashTag merged 2 commits into
masterfrom
fix/departure-is-not-repair

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

Refs #2325.

check_specs_generate.py built bad only from git ls-files "*.t27" and then computed fixed = known - bad. That folds two different events into one congratulation: a spec that started compiling, and a spec that stopped being tracked while still failing on disk.

Reproduced: untracking a debt spec prints NOTE 1 spec(s) in the baseline now generate and exits 0.

It has already happened at scale. Commit 2255e4c32 removed 58 ledger lines with 455 deletions and 0 modifications to the specs themselves — its own message concedes "those 58 would read as fixed, printing a false '58 spec(s) in the baseline now generate'."

Departure is now its own class: DEPARTED is reported by name and fails. fixed is (known & tracked) - bad, so it can only mean what it says. Control fires; the clean tree still exits 0 with 712 specs / 541 generating / 171 known-broken.

Not fixed here, filed instead: generates() returns True on rc == 0 alone and never opens the artefact, so a 0-byte spec counts as generating — and two tracked 0-byte specs exist. Larger change; belongs on its own.

🤖 Generated with Claude Code

check_specs_generate.py built `bad` only from `git ls-files "*.t27"` and
then computed `fixed = known - bad`. That folds two different events
into one congratulation: a spec that started compiling, and a spec that
stopped being TRACKED while still failing on disk.

Reproduced: untracking a debt spec prints "NOTE 1 spec(s) in the
baseline now generate" and exits 0.

It has already happened at scale. Commit 2255e4c removed 58 ledger
lines with 455 deletions and 0 modifications to the specs themselves --
its own message concedes "those 58 would read as fixed, printing a false
'58 spec(s) in the baseline now generate'."

Departure is now its own class: DEPARTED is reported by name and fails.
`fixed` is `(known & tracked) - bad`, so it can only ever mean what it
says. Control fires on an untracked debt spec; the clean tree still
exits 0 with 712 specs, 541 generating, 171 known-broken.

NOT fixed here, filed instead: `generates()` returns True on `rc == 0`
alone and never opens the artefact, so a 0-byte spec counts as
generating -- and two tracked 0-byte specs exist. That is a larger
change than this one and belongs on its own.

Refs #2325.
@gHashTag
gHashTag enabled auto-merge (squash) August 22, 2026 17:37
@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-22 17:37:53 UTC

Summary

Status Count
Total Open PRs 5
PRs with Failing Checks 2
PRs with All Checks Green 3
READY 2
FAILING 2
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=e905ba8eeb53 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-22 17:42:13 UTC

Summary

Status Count
Total Open PRs 5
PRs with Failing Checks 1
PRs with All Checks Green 4
READY 3
FAILING 1
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=e905ba8eeb53 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit 8c05e53 into master Aug 22, 2026
22 of 25 checks passed
@gHashTag
gHashTag deleted the fix/departure-is-not-repair branch October 26, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant