Repository navigation
fix(ci): a spec leaving the index is not a spec that got fixed - #2444
Merged
Merged
Conversation
check_specs_generate.py built `bad` only from `git ls-files "*.t27"` and then computed `fixed = known - bad`. That folds two different events into one congratulation: a spec that started compiling, and a spec that stopped being TRACKED while still failing on disk. Reproduced: untracking a debt spec prints "NOTE 1 spec(s) in the baseline now generate" and exits 0. It has already happened at scale. Commit 2255e4c removed 58 ledger lines with 455 deletions and 0 modifications to the specs themselves -- its own message concedes "those 58 would read as fixed, printing a false '58 spec(s) in the baseline now generate'." Departure is now its own class: DEPARTED is reported by name and fails. `fixed` is `(known & tracked) - bad`, so it can only ever mean what it says. Control fires on an untracked debt spec; the clean tree still exits 0 with 712 specs, 541 generating, 171 known-broken. NOT fixed here, filed instead: `generates()` returns True on `rc == 0` alone and never opens the artefact, so a 0-byte spec counts as generating -- and two tracked 0-byte specs exist. That is a larger change than this one and belongs on its own. Refs #2325.
gHashTag
enabled auto-merge (squash)
August 22, 2026 17:37
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-22 17:37:53 UTC
Summary
Seal Status
|
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-22 17:42:13 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2325.
check_specs_generate.pybuiltbadonly fromgit ls-files "*.t27"and then computedfixed = known - bad. That folds two different events into one congratulation: a spec that started compiling, and a spec that stopped being tracked while still failing on disk.Reproduced: untracking a debt spec prints
NOTE 1 spec(s) in the baseline now generateand exits 0.It has already happened at scale. Commit
2255e4c32removed 58 ledger lines with 455 deletions and 0 modifications to the specs themselves — its own message concedes "those 58 would read as fixed, printing a false '58 spec(s) in the baseline now generate'."Departure is now its own class:
DEPARTEDis reported by name and fails.fixedis(known & tracked) - bad, so it can only mean what it says. Control fires; the clean tree still exits 0 with 712 specs / 541 generating / 171 known-broken.Not fixed here, filed instead:
generates()returns True onrc == 0alone and never opens the artefact, so a 0-byte spec counts as generating — and two tracked 0-byte specs exist. Larger change; belongs on its own.🤖 Generated with Claude Code